Add code to check for staleness in labelstore #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
commented
Dec 13, 2023
thampiotr
reviewed
Dec 13, 2023
Comment on lines
+25
to
+26
| totalIDs *prometheus.Desc | ||
| idsInRemoteWrapping *prometheus.Desc |
There was a problem hiding this comment.
Could these be constants in the package?
| // Run starts a Service. Run must block until the provided | ||
| // context is canceled. Returning an error should be treated | ||
| // as a fatal error for the Service. | ||
| func (s *service) Run(ctx context.Context, host agent_service.Host) error { | ||
| <-ctx.Done() | ||
| return nil | ||
| staleCheck := time.NewTicker(10 * time.Minute) |
There was a problem hiding this comment.
We probably don't need to do this now, but do you think there may be a need to configure this in the future?
There was a problem hiding this comment.
Since staleness markers arent configurable and this was meant to be double the staleness marker length I dont think it will need to be configurable. Though that is famous last words.
thampiotr
approved these changes
Dec 15, 2023
thampiotr
reviewed
Dec 15, 2023
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* Add code to check for staleness which touched a ton of tests since I also added metrics. * Update metric * Add explicit _ for register * pr feedback on changing to gauges * updated comment with test results
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This wires up the staleness check from the labelstore that will ideally reduce memory usage in high cardinality or high churn environments.
Which issue(s) this PR fixes
Closes #5585
Notes to the Reviewer
PR Checklist